Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter & chart header UI enhancements #283

Merged
merged 2 commits into from
Oct 12, 2020
Merged

filter & chart header UI enhancements #283

merged 2 commits into from
Oct 12, 2020

Conversation

deveshchatuphale7
Copy link
Contributor

Related Issue

Fixes #17

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)

  • Optional: Add any explanations here
    Modified CSS & HTML for filter-panel component. Also added classes to dashboard components from bootstrap & root.css

  • Optional: Add any relevant screenshots here

github-actions[bot]
github-actions bot reviewed Oct 11, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your first PR to this repository. We appreciate your contribution! Our team will review your code within 3 business days. We <3 open source and are so glad you do, too!

Sheeri
Sheeri requested changes Oct 11, 2020
View reviewed changes
Copy link
Collaborator

@Sheeri Sheeri left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! It looks like the number next to the filter icon is the number of available filters. This isn't your fault, it wasn't specified, but the number should be the number of filters actually being used - regardless of how many there are. So when the page first loads, there should be no number, because no filters are being applied.
Screen Shot 2020-10-11 at 2 03 54 PM

Also, on my install I'm seeing broken images for the 'down arrow' next to the filters as well as the dates:
Screen Shot 2020-10-11 at 2 05 03 PM

Screen Shot 2020-10-11 at 2 05 30 PM

@deveshchatuphale7
Copy link
Contributor Author

I have updated logic in filter-panel component to show count of applied filters. I am not sure why down arrow is broken, working fine at my end

Screenshot_2020-10-12 O-FISH

Let me know if latest commit solves the issue.
Thank you

@Sheeri Sheeri merged commit 1cd9217 into WildAid:main Oct 12, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 12, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is fantastic and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

@Sheeri
Copy link
Collaborator

Sheeri commented Oct 19, 2020

Hi @deveshchatuphale7!
We noticed you haven't claimed your digital MongoDB swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

@deveshchatuphale7
Copy link
Contributor Author

Hi @deveshchatuphale7!
We noticed you haven't claimed your digital MongoDB swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

Sure! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Sheeri Sheeri Sheeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web: Skinning - Dashboard should look like this
2 participants
@deveshchatuphale7 @Sheeri